[PATCH 2/3] nvmet: pci-epf: Clear CC and CSTS when disabling the controller

Damien Le Moal dlemoal at kernel.org
Thu Apr 10 17:35:44 PDT 2025


On 4/10/25 20:54, Niklas Cassel wrote:
>> +static void nvmet_pci_epf_clear_ctrl_config(struct nvmet_pci_epf_ctrl *ctrl)
>> +{
>> +	struct nvmet_ctrl *tctrl = ctrl->tctrl;
>> +
>> +	/* Initialize controller status. */
>> +	tctrl->csts = 0;
>> +	ctrl->csts = 0;
> 
> This can be written on one line:
> tctrl->csts = ctrl->csts = 0;

I am aware of this, but really dislike this style as I think it makes the code
less readable. So unless the nvme maintainers insist on this change, I prefer
leaving this as I wrote it.


-- 
Damien Le Moal
Western Digital Research



More information about the Linux-nvme mailing list