[PATCH 1/3] nvmet: pci-epf: Always fully initialize completion entries

Christoph Hellwig hch at lst.de
Thu Apr 10 01:38:30 PDT 2025


On Tue, Apr 08, 2025 at 11:47:31AM +0900, Damien Le Moal wrote:
> @@ -1763,6 +1763,8 @@ static void nvmet_pci_epf_cq_work(struct work_struct *work)
>  
>  		/* Post the IOD completion entry. */
>  		cqe = &iod->cqe;
> +		cqe->sq_id = cpu_to_le16(iod->sq->qid);
> +		cqe->command_id = iod->cmd.common.command_id;

This could use a comment explaining why we are doing this seemingly
duplicate work here.

Otherwise this looks good to me.



More information about the Linux-nvme mailing list