nvme-cli connect regression

[Daniel Wagner]

On Mon, Apr 07, 2025 at 11:01:00AM +0200, Maurizio Lombardi wrote:
> On Mon Apr 7, 2025 at 10:34 AM CEST, Daniel Wagner wrote:
> > On Tue, Apr 01, 2025 at 02:40:54PM -0700, Caleb Sander Mateos wrote:
> >> I am not sure what an error code of EINTR means in the kernel. It
> >> looks like the kernel_recvmsg() is performed on the thread that writes
> >> to /dev/nvme-fabrics, so it's possible that there is a signal pending
> >> for the userspace thread (i.e. nvme-cli)?
> >
> > nvme-cli has only on place where signals are used (to interrupt a self
> > test). libnvme doesn't use signals at all. No idea where the signal is
> > coming from but it looks very unlikely to be from nvme-cli/libnvme.
> 
> Maybe an operation on a socket that has been closed by the other side (SIGPIPE) ?

Could be.

Anyway, no one has really said it's a stupid idea to retry when the
syscall returns EINTR, so I am going to add it to libnvme now.