[PATCH V4 2/2] nvme-tcp: do not complete the request if send operation fails

Hannes Reinecke hare at suse.de
Sun Apr 6 23:13:27 PDT 2025


On 4/4/25 10:28, Maurizio Lombardi wrote:
> In some cases, the send operation may fail even though
> the command is successfully received by the target.
> The target then sends a command completion capsule back to the host,
> leading to double completion and a kernel panic.
> 
> To prevent this, do not fail the request; instead, let the
> error recovery mechanism clean everything up.
> 
> Tested-by: Zhang Guanghui <zhang.guanghui at cestc.cn>
> Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
> Signed-off-by: Maurizio Lombardi <mlombard at redhat.com>
> ---
>   drivers/nvme/host/tcp.c | 14 --------------
>   1 file changed, 14 deletions(-)
> 
You could have merged it with the previous patch, but that's more or
less cosmetical.

Reviewed-by: Hannes Reinecke <hare at suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich



More information about the Linux-nvme mailing list