[PATCH] nvme-cli: attach ns to local controller if none specified
Daniel Wagner
dwagner at suse.de
Tue Apr 1 00:32:50 PDT 2025
On Mon, Mar 31, 2025 at 09:16:49PM +0000, Chaitanya Kulkarni wrote:
> On 3/31/25 13:57, Keith Busch wrote:
> > On Mon, Mar 31, 2025 at 08:37:31PM +0000, Chaitanya Kulkarni wrote:
> > > if not then do we need add a version check so it will stay as backward
> > > compatible ?
> > I don't follow what you mean here. What version of what component could
> > be checked to guide this behavior?
>
> if we can only enable this functionality for nvme-cli/libnvme for the
> current version and any other versions after current version.
This is a new feature which is backwards compatible as I understand it.
If a user provides the -c option it still does exactly what it supposed
to do.
> In case nvme-cli or libnvme has a version below the current version, then
> it can follow the original behavior, will this work or not ?
Older version will complain, that you need to provide the controller id,
newer ones will just assume you wanted the first controller.
For extra points, this could be documented in the docs :)
More information about the Linux-nvme
mailing list