[PATCH] nvme: null terminate nvme_tls_attrs

[Yi Zhang]

On Tue, Sep 24, 2024 at 5:01 PM Shin'ichiro Kawasaki
<shinichiro.kawasaki at wdc.com> wrote:
>
> Commit 1e48b34c9bc7 ("nvme: split off TLS sysfs attributes into a
> separate group") introduced the struct attribute array nvme_tls_attrs.
> However, the array was not null terminated and caused BUG KASAN global-
> out-of-bounds. To avoid the BUG, null terminate the array.
>
> Reported-by: Yi Zhang <yi.zhang at redhat.com>
> Closes: https://lore.kernel.org/linux-nvme/jhllwfxcedrcxcnbajwl4x2l2ujcqowqcd4ps574zrafrqhjna@f4icvecutekm/
> Fixes: 1e48b34c9bc7 ("nvme: split off TLS sysfs attributes into a separate group")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki at wdc.com>
> ---
>  drivers/nvme/host/sysfs.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
> index eb345551d6fe..b68a9e5f1ea3 100644
> --- a/drivers/nvme/host/sysfs.c
> +++ b/drivers/nvme/host/sysfs.c
> @@ -767,6 +767,7 @@ static struct attribute *nvme_tls_attrs[] = {
>         &dev_attr_tls_key.attr,
>         &dev_attr_tls_configured_key.attr,
>         &dev_attr_tls_keyring.attr,
> +       NULL,
>  };
>
>  static umode_t nvme_tls_attrs_are_visible(struct kobject *kobj,
> --
> 2.45.2
>

Verified the issue was fixed.

Tested-by: Yi Zhang <yi.zhang at redhat.com>


--
Best Regards,
  Yi Zhang