[PATCH] nvmet-passthru: allow nvme ns-id descriptor list to clear EUID/NGUID/UUID

Nilay Shroff nilay at linux.ibm.com
Sat Sep 21 00:05:58 PDT 2024



On 9/20/24 22:19, Keith Busch wrote:
> On Tue, Sep 17, 2024 at 02:21:04PM +0530, Nilay Shroff wrote:
>> @@ -547,7 +543,11 @@ u16 nvmet_parse_passthru_admin_cmd(struct nvmet_req *req)
>>  				return NVME_SC_SUCCESS;
>>  			}
>>  			return NVME_SC_INVALID_OPCODE | NVME_STATUS_DNR;
>> +		case NVME_ID_CNS_CTRL:
>> +			fallthrough;
>>  		case NVME_ID_CNS_NS:
>> +			fallthrough;
>> +		case NVME_ID_CNS_NS_DESC_LIST:
> 
> I'm pretty sure you only need the "fallthrough" statement when you other
> statements inbetween the cases.
> 
Alright, I think you prefer combining all three cases together without any
fallthrough in-between them and yes I believe that would also work. I will 
send the next patch including yours as well Christoph review comment addressed.

Thank,
--Nilay



More information about the Linux-nvme mailing list