[PATCH 4/4] nvme: remove existing namespace on ID mismatch

Sagi Grimberg sagi at grimberg.me
Mon Sep 2 10:01:21 PDT 2024


Again, patch title should describe what it is fixing.


On 02/09/2024 14:15, Hannes Reinecke wrote:
> When the namespace IDs mismatch during rescan we clearly ran out of
> sync with the target,

Not clear at all. When can this happen and how?

>   but we really can't know whether our local copy
> of the NSID is correct, and that one found by scanning is not.
> But clearly something is wrong with the namespaces, so we should remove
> the existing one, too, to avoid accidental data corruption.

Umm. So you see a bogus ns and conflicting with another ns which is
seemingly fine and you remove it?

I feel like you are describing something "generically useful/correct" 
while you address
a very specific problem but you don't describe it to us...



More information about the Linux-nvme mailing list