[PATCH] nvme/{common/nvme, 051, 052}: introduce def_nsid

[Shinichiro Kawasaki]

On Oct 30, 2024 / 17:44, Guixin Liu wrote:
> 
> 在 2024/10/30 15:31, Shinichiro Kawasaki 写道:
> > On Oct 29, 2024 / 11:19, Guixin Liu wrote:
> > > Use def_nsid instead of hard code, the default of def_nsid is 1.
> > Hi Guixin, thnaks for the patch.
> > 
> > May I know the motivation to introduce def_nsid? Does it aim to improve code
> > readability? Or does it aim to allow testing various def_nsid values?
> 
> Just like def_subsysnqn and def_subsys_uuid, avoid hard code in testcases,
> 
> and let us to know the ns_id created by default.

Thank you, I see it. I think Chaitanya finds the same value.

I forgot to mention that your v1 patch has this shellcheck waning:

  tests/nvme/052:63:15: note: $/${} is unnecessary on arithmetic variables. [SC2004]

It will be appreciated to address it, and run "make check" for confirmation.