[PATCH 1/3] Revert "nvme: make keep-alive synchronous operation"

[Ming Lei]

On Mon, Oct 28, 2024 at 1:03 AM Nilay Shroff <nilay at linux.ibm.com> wrote:
>
> This reverts commit d06923670b5a5f609603d4a9fee4dec02d38de9c.
> This reverts commit 599d9f3a10eec69ef28a90161763e4bd7c9c02bf.
>
> It was realized that the fix implemented to avoid the race
> condition between keep alive task and the fabric shutdown code
> path in the commit d06923670b5ia ("nvme: make keep-alive
> synchronous operation") is not optimal.

I saw you have discussed it a while, but it is still better to describe
the reason in the commit log.

>
> We also found that the above race condition is regression caused
> due to the changes implemented in commit a54a93d0e359 ("nvme: move
> stopping keep-alive into nvme_uninit_ctrl()"). So we decided to

Can you explain a bit why commit a54a93d0e359 is a regression?
And what is the race condition?

Without providing the context info, it is hard to review the change.

Thanks,