[PATCH blktests 03/15] nvme: sanitize transport parameter in _create_nvmet_port()

[Shinichiro Kawasaki]

On Oct 25, 2024 / 16:11, Daniel Wagner wrote:
> On Thu, Oct 24, 2024 at 10:00:13AM GMT, Shin'ichiro Kawasaki wrote:
> > From: Hannes Reinecke <hare at suse.de>
> > 
> > We need to sanitize the transport parameters in _create_nvmet_port()
> > to avoid having invalid transport values when selecting a transport
> > type.
> 
> Hmm, I miss the important point that this change add support for more
> than one connection (ports).

Agreed. I will add a sentence to the commit message, like,

   This change allows the function support more than one port.

> 
> > Signed-off-by: Hannes Reinecke <hare at suse.de>
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki at wdc.com>
> 
> Except the commit message nitpick, looks good.
> 
> Reviewed-by: Daniel Wagner <dwagner at suse.de>
>