[PATCH blktests 11/15] common/nvme, nvme/003: add --no_port option to _nvme_connect_subsys

[Daniel Wagner]

On Thu, Oct 24, 2024 at 10:00:21AM GMT, Shin'ichiro Kawasaki wrote:
> Commit "nvme: pass in port parameter to _nvme_connect_subsys()"
> introduced the --port argument to _nvme_connect_subsys(). If the option
> is not specified, _nvme_connect_subsys() automatically finds the port
> for the specified subsysnqn. However, this does not work for the test
> case nvme/003, since the test case connects to the subsys for discovery,
> then, the port of the created subsysnqn is not to be used. This causes
> the failure of the test case.
>
> To avoid the failure, introduce --no_port option. When this is option is
> specified, _nvme_connect_subsys() skips the port finding step.

Can't we just figure out from the subsys name if we need to use the
default ports directly? I am not so sure about the --no_port argument
is a good idea. And if a test wants to use a specific port, we have the
port option, no?