[PATCH] nvme: module parameter to disable pi checks

[David Wei]

On 2024-10-23 13:21, Keith Busch wrote:
> On Wed, Oct 23, 2024 at 08:01:43PM +0000, Chaitanya Kulkarni wrote:
>> @@ -1774,9 +1773,9 @@ static bool nvme_init_integrity(struct 
>> nvme_ns_head *head,
>>                  return nvme_ns_has_pi(head);
>>
>>          if (disable_pi)
>> -               pi_type = 0;
>> +               goto out;
> 
> I'm not against 'goto' in principle, but I try to restrict it to
> unwinding an error, and this isn't an error. I know, personal preference
> and all...

Agreed. This is more unreadable and a modern compiler will most likely
do the right thing anyway.