[PATCHv2] nvme: enhance cns version checking

Keith Busch kbusch at kernel.org
Tue Oct 22 09:19:21 PDT 2024


On Fri, Oct 18, 2024 at 07:12:01AM +0200, Christoph Hellwig wrote:
> On Thu, Oct 17, 2024 at 11:12:31AM -0700, Keith Busch wrote:
> > +	if (ctrl->vs >= NVME_VS(1, 1, 0) &&
> > +	    (!(ctrl->quirks & NVME_QUIRK_IDENTIFY_CNS)))
> 
> No need for the braces around the ngation here.
> 
> > +		return cns <= 3;
> > +
> > +	/*
> > +	 * NVMe 1.0 used a single bit for the CNS value.
> > +         */
> > +	return cns <= 1;
> 
> Slightly messed up indentation.

Fixed up, and applied to nvme-6.12.



More information about the Linux-nvme mailing list