[PATCH] nvme-loop: set blocking flag

[Shinichiro Kawasaki]

On Oct 22, 2024 / 09:02, Christoph Hellwig wrote:
> On Tue, Oct 22, 2024 at 08:28:10AM +0200, Christoph Hellwig wrote:
> > On Mon, Oct 21, 2024 at 12:35:17AM +0300, Sagi Grimberg wrote:
> > >> Let me see what I can do.
> > >
> > > Note, the search is ONLY in the error case, i.e. when nsid is not found in
> > > subsys->namespaces.
> > 
> > Which kinda makes it worse as we use an unusual context just from
> > that rare error path.
> 
> I just took a very quick look, and inserting the namespace into the
> xarray when created and only removing it when it is deleted, and
> instead checking an enabled flag during lookup should do the work.
> 
> Do we have a good test case for commit 505363957fad ?

As for the BUG caused by the commit 505363957fad, the blktests test case
nvme/052 can confirm if any patch fixes the BUG or not. It is recreate in
stable manner on my test node [1], so I'm happy to help testing.

If you mean a test case to confirm that the commit 505363957fad achieves its
purpose, I'm not sure about it. According to its commit log, I guess Jirong
might have a test environment.

[1] https://lore.kernel.org/linux-nvme/tqcy3sveity7p56v7ywp7ssyviwcb3w4623cnxj3knoobfcanq@yxgt2mjkbkam/