[PATCHv2] nvme: enhance cns version checking
Christoph Hellwig
hch at lst.de
Thu Oct 17 22:12:01 PDT 2024
On Thu, Oct 17, 2024 at 11:12:31AM -0700, Keith Busch wrote:
> + if (ctrl->vs >= NVME_VS(1, 1, 0) &&
> + (!(ctrl->quirks & NVME_QUIRK_IDENTIFY_CNS)))
No need for the braces around the ngation here.
> + return cns <= 3;
> +
> + /*
> + * NVMe 1.0 used a single bit for the CNS value.
> + */
> + return cns <= 1;
Slightly messed up indentation.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
More information about the Linux-nvme
mailing list