[PATCH] nvme-loop: set blocking flag

Jens Axboe axboe at kernel.dk
Thu Oct 17 10:39:24 PDT 2024


On 10/17/24 11:20 AM, Keith Busch wrote:
> From: Keith Busch <kbusch at kernel.org>
> 
> Commit 505363957fad ("nvmet: fix nvme status code when namespace is
> disabled") introduced a mutex lock in the io path for target. The loop
> target connects this to the blk-mq submission side, so it requires the
> blocking flag set so that queue_rq doesn't happen inside an rcu context.

Looks fine to me, but might be worth looking at doing that a bit
differently so that the target loop driver can remain non-blocking
as it should be considerably more efficient.

-- 
Jens Axboe




More information about the Linux-nvme mailing list