[PATCH blktests v5 2/2] nvme: test the nvme reservation feature

[Daniel Wagner]

On Tue, Oct 15, 2024 at 10:43:50AM GMT, Guixin Liu wrote:
> Test the NVMe reservation feature, including register, acquire,
> release and report.
> 
> Signed-off-by: Guixin Liu <kanie at linux.alibaba.com>
> Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>

Looks good to me. Thanks!

Reviewed-by: Daniel Wagner <dwagner at suse.de>

> ---
>  tests/nvme/054     | 101 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/nvme/054.out |  68 ++++++++++++++++++++++++++++++
>  2 files changed, 169 insertions(+)
>  create mode 100644 tests/nvme/054
>  create mode 100644 tests/nvme/054.out
> 
> diff --git a/tests/nvme/054 b/tests/nvme/054
> new file mode 100644
> index 0000000..71c625c
> --- /dev/null
> +++ b/tests/nvme/054
> @@ -0,0 +1,101 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-3.0+
> +# Copyright (C) 2024 Guixin Liu
> +# Copyright (C) 2024 Alibaba Group.
> +#
> +# Test the NVMe reservation feature
> +#
> +. tests/nvme/rc
> +
> +DESCRIPTION="Test the NVMe reservation feature"
> +QUICK=1
> +nvme_trtype="loop"
> +
> +requires() {
> +	_nvme_requires
> +}
> +
> +resv_report() {
> +	local test_dev=$1
> +	local report_arg=$2
> +
> +	nvme resv-report "${test_dev}" "${report_arg}" | grep -v "hostid" | \
> +		grep -E "gen|rtype|regctl|regctlext|cntlid|rcsts|rkey"
> +}
> +
> +test_resv() {
> +	local ns=$1
> +	local report_arg="--cdw11=1"
> +	test_dev="/dev/${ns}"
> +
> +	if nvme resv-report --help 2>&1 | grep -- '--eds' > /dev/null; then
> +		report_arg="--eds"
> +	fi
> +
> +	echo "Register"
> +	resv_report "${test_dev}" "${report_arg}"
> +	nvme resv-register "${test_dev}" --nrkey=4 --rrega=0
> +	resv_report "${test_dev}" "${report_arg}"
> +
> +	echo "Replace"
> +	nvme resv-register "${test_dev}" --crkey=4 --nrkey=5 --rrega=2
> +	resv_report "${test_dev}" "${report_arg}"
> +
> +	echo "Unregister"
> +	nvme resv-register "${test_dev}" --crkey=5 --rrega=1
> +	resv_report "${test_dev}" "${report_arg}"
> +
> +	echo "Acquire"
> +	nvme resv-register "${test_dev}" --nrkey=4 --rrega=0
> +	nvme resv-acquire "${test_dev}" --crkey=4 --rtype=1 --racqa=0
> +	resv_report "${test_dev}" "${report_arg}"
> +
> +	echo "Preempt"
> +	nvme resv-acquire "${test_dev}" --crkey=4 --rtype=2 --racqa=1
> +	resv_report "${test_dev}" "${report_arg}"
> +
> +	echo "Release"
> +	nvme resv-release "${test_dev}" --crkey=4 --rtype=2 --rrela=0
> +	resv_report "${test_dev}" "${report_arg}"
> +
> +	echo "Clear"
> +	nvme resv-register "${test_dev}" --nrkey=4 --rrega=0
> +	nvme resv-acquire "${test_dev}" --crkey=4 --rtype=1 --racqa=0
> +	resv_report "${test_dev}" "${report_arg}"
> +	nvme resv-release "${test_dev}" --crkey=4 --rrela=1
> +}
> +
> +test() {
> +	echo "Running ${TEST_NAME}"
> +
> +	_setup_nvmet
> +
> +	local ns
> +	local skipped=false
> +	local subsys_path=""
> +	local ns_path=""
> +
> +	_nvmet_target_setup --blkdev file --resv_enable
> +	subsys_path="${NVMET_CFS}/subsystems/${def_subsysnqn}"
> +	_nvme_connect_subsys
> +
> +	ns=$(_find_nvme_ns "${def_subsys_uuid}")
> +	ns_id=$(echo "${ns}" | grep -oE '[0-9]+' | sed -n '2p')
> +	ns_path="${subsys_path}/namespaces/${ns_id}"
> +
> +	if [[ -f "${ns_path}/resv_enable" ]] ; then
> +		test_resv "${ns}"
> +	else
> +		SKIP_REASONS+=("missing reservation feature")
> +		skipped=true
> +	fi
> +
> +	_nvme_disconnect_subsys
> +	_nvmet_target_cleanup
> +
> +	if [[ "${skipped}" = true ]] ; then
> +		return 1
> +	fi
> +
> +	echo "Test complete"
> +}
> diff --git a/tests/nvme/054.out b/tests/nvme/054.out
> new file mode 100644
> index 0000000..5adb30d
> --- /dev/null
> +++ b/tests/nvme/054.out
> @@ -0,0 +1,68 @@
> +Running nvme/054
> +Register
> +gen       : 0
> +rtype     : 0
> +regctl    : 0
> +NVME Reservation  success
> +gen       : 1
> +rtype     : 0
> +regctl    : 1
> +regctlext[0] :
> +  cntlid     : ffff
> +  rcsts      : 0
> +  rkey       : 4
> +Replace
> +NVME Reservation  success
> +gen       : 2
> +rtype     : 0
> +regctl    : 1
> +regctlext[0] :
> +  cntlid     : ffff
> +  rcsts      : 0
> +  rkey       : 5
> +Unregister
> +NVME Reservation  success
> +gen       : 3
> +rtype     : 0
> +regctl    : 0
> +Acquire
> +NVME Reservation  success
> +NVME Reservation Acquire success
> +gen       : 4
> +rtype     : 1
> +regctl    : 1
> +regctlext[0] :
> +  cntlid     : ffff
> +  rcsts      : 1
> +  rkey       : 4
> +Preempt
> +NVME Reservation Acquire success
> +gen       : 5
> +rtype     : 2
> +regctl    : 1
> +regctlext[0] :
> +  cntlid     : ffff
> +  rcsts      : 1
> +  rkey       : 4
> +Release
> +NVME Reservation Release success
> +gen       : 5
> +rtype     : 0
> +regctl    : 1
> +regctlext[0] :
> +  cntlid     : ffff
> +  rcsts      : 0
> +  rkey       : 4
> +Clear
> +NVME Reservation  success
> +NVME Reservation Acquire success
> +gen       : 6
> +rtype     : 1
> +regctl    : 1
> +regctlext[0] :
> +  cntlid     : ffff
> +  rcsts      : 1
> +  rkey       : 4
> +NVME Reservation Release success
> +disconnected 1 controller(s)
> +Test complete
> -- 
> 2.43.0
>