[PATCH 1/3] nvme-multipath: simplify loop in nvme_update_ana_state()
Christoph Hellwig
hch at lst.de
Mon Oct 7 23:39:17 PDT 2024
On Mon, Oct 07, 2024 at 09:46:16AM -0600, Keith Busch wrote:
> This patch looks good to me.
>
> Your commit log is word wrapping a bit short, though. We standardize on
> 72 characters.
The for loop is also missing a space before the opening brace while
we're nitpicking.
The reason the code was written this way is that when there are a lot
of namespace in an update we now need to a full list scan for each
one, which can add a lot of overhead. So I guess we'll need to see
why it is important to change it to counter that tradeoff.
More information about the Linux-nvme
mailing list