[PATCH v11 1/1] nvmet: support reservation feature

[Christoph Hellwig]

On Sat, Oct 05, 2024 at 11:09:20PM +0800, Guixin Liu wrote:
>>> +struct nvmet_pr_register_data {
>>> +	__le64	crkey;
>>> +	__le64	nrkey;
>>> +};
>>> +
>>> +struct nvmet_pr_acquire_data {
>>> +	__le64	crkey;
>>> +	__le64	prkey;
>>> +};
>>> +
>>> +struct nvmet_pr_release_data {
>>> +	__le64	crkey;
>>> +};
>> Using little endian fields for purely in-memory data feels strange.
>> Is there a good reason for this?
>>
> I use nvmet_copy_from_sgl to obtain the command's detail, just like
>
> nvme_dsm_range, maybe I can put them in to include/linux/nvme.h.

Ah right, you just store the on the wire format locally.  Yes,
pleaße ad them to nvme.h.