[PATCH blktests] nvme: delete all namespaces in _remove_nvmet_subsystem()

[Daniel Wagner]

On Wed, Nov 20, 2024 at 07:20:51PM +0900, Shin'ichiro Kawasaki wrote:
> From: Hannes Reinecke <hare at suse.de>
> 
> A subsystem might have more than one namespace, so delete all of them in
> _remove_nvmet_subsystem().
> 
> This change was to be made before the commit 67e25d71bc58 ("nvme/052: do
> not create namespace when setting up the target"), which assumes that
> _remove_nvmet_subsystem() delets all namespaces. However, commit order
> was modified then the test case nvme/052 now fails without this commit.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.de>
> [Shin'ichiro: resolved conflicts]
> Fixes: 67e25d71bc58 ("nvme/052: do not create namespace when setting up the target")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki at wdc.com>
> ---
> This patch is a part of the ANA support work by Hannes. It was once included in
> the first series of the work, but it was dropped from the series to be included
> in the later series [1]. After the second series of the work was applied, Yi
> Zhang found nvme/052 fails [2]. It turned out that this patch is required for
> the one of the patches in the second series, which is the commit 67e25d71bc58
> ("nvme/052: do not create namespace when setting up the target").
> 
> Of note is that this patch also prepares for one of the new test cases to be
> included in the third series [3].
> 
> [1] https://lore.kernel.org/linux-nvme/20241024010025.2216242-14-shinichiro.kawasaki@wdc.com/
> [2] https://lore.kernel.org/linux-nvme/20241120024925.1397864-1-yi.zhang@redhat.com/
> [3] https://github.com/kawasaki/blktests/commit/31091d116eaea4e7d5ad3cf76e106d1085209c07

I see, I hoped we don't need it, as I do prefer to have explicit stuff.

Reviewed-by: Daniel Wagner <dwagner at suse.de>