[PATCH v2] nvme-core: auto add the new ns while UUID changed

许春光 brookxu.cn at gmail.com
Fri Nov 15 16:49:12 PST 2024


Christoph Hellwig <hch at lst.de> 于2024年11月16日周六 01:04写道:
>
> On Fri, Nov 15, 2024 at 04:37:27PM +0800, brookxu.cn wrote:
> > From: "Chunguang.xu" <chunguang.xu at shopee.com>
> >
> > Now spdk will change UUID of ns while restarted if we have not
> > specified one. At this time, while host try to reconnected to target,
> > as UUID have changed, we will remove the old ns, but not add the ns
> > with the new UUID.
>
> And that is broken behavior.  The host must assume the namespace has
> been deleted and recreated when the eui/nguid/uuid change, and we need
> to catch this.
Yes, now we have remove the old ns and log the change to dmesg,  but I am
confused why not auto add the ns with new UUID, we should treat it as a new
ns? so that we can avoid an active controller with no ns, but actually it have
one.

>Fix your broken target code instead.
>



More information about the Linux-nvme mailing list