[PATCH blktests 3/8] nvme/016: do not create namespace when setting up the target

Shinichiro Kawasaki shinichiro.kawasaki at wdc.com
Thu Nov 14 03:04:42 PST 2024


On Nov 11, 2024 / 11:38, Daniel Wagner wrote:
> On Thu, Nov 07, 2024 at 08:13:49PM +0900, Shin'ichiro Kawasaki wrote:
> > -	_create_nvmet_subsystem --blkdev "${loop_dev}"
> > +	_create_nvmet_subsystem
> 
> After reading patch #5, should this be
> 
>   _create_nvmet_subsystem --blkdev none

I agree that this change is not straight forwared. Please refer the commit
fe6cd136 ("nvme, md/001: support only long options for
_create_nvmet_subsystem()"). It was the last commit of the first series [1].
(I should have included the patch in this second series...)

[1] https://lore.kernel.org/linux-nvme/20241030065149.2297405-14-shinichiro.kawasaki@wdc.com/

It added one if block below in the middle of _create_nvmet_subsystem.

       if [[ -z "${blkdev}" ]]; then
               return 0
       fi

Then, when --blkdev option is not specified, _create_nvmet_subsystem does not
create namespaces. So just removing the --blkdev option does the change
required. Same for the next patch and nvme/017.


More information about the Linux-nvme mailing list