[PATCH] nvme: use BIT_MASK and GENMASK for NVME definitions

[Christoph Hellwig]

On Thu, Nov 14, 2024 at 12:14:33AM +0900, Tokunori Ikegami wrote:
> On 2024/11/12 13:26, Christoph Hellwig wrote:
> > > -	NVME_CMBSZ_CQS		= 1 << 1,
> > > -	NVME_CMBSZ_LISTS	= 1 << 2,
> > > -	NVME_CMBSZ_RDS		= 1 << 3,
> > > -	NVME_CMBSZ_WDS		= 1 << 4,
> > > +	NVME_CMBSZ_SQS		= BIT_MASK(0),
> > > +	NVME_CMBSZ_CQS		= BIT_MASK(1),
> > > +	NVME_CMBSZ_LISTS	= BIT_MASK(2),
> > > +	NVME_CMBSZ_RDS		= BIT_MASK(3),
> > > +	NVME_CMBSZ_WDS		= BIT_MASK(4),
> > Nothjing genmask here, and a lot less readable for no good reason at
> > all.
> Is it still no good to change BIT_MASK() to BIT()?

No, why would it be?