[PATCH v1 04/17] dma-mapping: Add check if IOVA can be used

Greg Sword gregsword0 at gmail.com
Sun Nov 10 23:19:48 PST 2024


On Mon, Nov 11, 2024 at 2:39 PM Christoph Hellwig <hch at lst.de> wrote:
>
> On Sun, Nov 10, 2024 at 04:09:11PM +0100, Zhu Yanjun wrote:
> >> +
> >> +/*
> >> + * Use the high bit to mark if we used swiotlb for one or more ranges.
> >> + */
> >> +#define DMA_IOVA_USE_SWIOTLB                (1ULL << 63)
> >
> > A trivial problem.
> > In the above macro, using BIT_ULL(63) is better?
>
> No, and can people please stop suggesting it?  That macro is so fucking
> pointless that it's revolting,

Why do you hate this macro so much, have you considered the feelings
of the macro author?

>
>



More information about the Linux-nvme mailing list