[PATCHv4 04/13] nvmet: implement supported features log

[Christoph Hellwig]

On Thu, Nov 07, 2024 at 11:38:39AM -0800, Keith Busch wrote:
> +	features->fis[NVME_FEAT_NUM_QUEUES] = cpu_to_le32(NVME_FIS_FSUPP |
> +							  NVME_FIS_CSCPE);
> +	features->fis[NVME_FEAT_KATO] = cpu_to_le32(NVME_FIS_FSUPP |
> +						    NVME_FIS_CSCPE);

Totally nitpicky, but I find this version much easier to read:

	features->fis[NVME_FEAT_NUM_QUEUES] =
		cpu_to_le32(NVME_FIS_FSUPP | NVME_FIS_CSCPE);
	features->fis[NVME_FEAT_KATO] =
		cpu_to_le32(NVME_FIS_FSUPP | NVME_FIS_CSCPE);

especially if the number of flags keeps growing.

Either way this looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>