[PATCHv4 05/13] nvmet: implement crto property

Matias Bjørling m at bjorling.me
Fri Nov 8 04:34:05 PST 2024


On 07-11-2024 20:38, Keith Busch wrote:
> From: Keith Busch <kbusch at kernel.org>
> 
> This property is required for nvme 2.1. The target only supports ready
> with media, so this is just the same value as CAP.TO.
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Signed-off-by: Keith Busch <kbusch at kernel.org>
> ---
>   drivers/nvme/target/fabrics-cmd.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
> index c4b2eddd5666a..bb80db6a7950b 100644
> --- a/drivers/nvme/target/fabrics-cmd.c
> +++ b/drivers/nvme/target/fabrics-cmd.c
> @@ -64,6 +64,9 @@ static void nvmet_execute_prop_get(struct nvmet_req *req)
>   		case NVME_REG_CSTS:
>   			val = ctrl->csts;
>   			break;
> +		case NVME_REG_CRTO:
> +			val = NVME_CAP_TIMEOUT(ctrl->csts);
> +			break;
>   		default:
>   			status = NVME_SC_INVALID_FIELD | NVME_STATUS_DNR;
>   			break;

Looks good.

Reviewed-by: Matias Bjørling <matias.bjorling at wdc.com>



More information about the Linux-nvme mailing list