[PATCHv3 11/11] nvme: add rotational support

[Christoph Hellwig]

On Wed, Nov 06, 2024 at 03:57:06PM +0800, Guixin Liu wrote:
> May I pose a question, what does BLK_FEAT_ADD_RANDOM do?

Nothing.

> I see the scsi call add_disk_randomness() in scsi_end_request() if 
> request_queue has

Yes.

>
> BLK_FEAT_ADD_RANDOM flag, but I dont see any calls in the patchset.

I actually pointed that out last round and thought it got fixed,
should have noticed it wasn't this time around.  The flag really
should be dropped.