[PATCHv3 06/11] nvmet: declare 2.1 version compliance

[Chaitanya Kulkarni]

On 11/5/24 21:45, Christoph Hellwig wrote:
> On Tue, Nov 05, 2024 at 09:48:59AM -0800, Keith Busch wrote:
>> From: Keith Busch <kbusch at kernel.org>
>>
>> The target driver implements all the mandatory logs, identifications,
>> features, and properties up to nvme sepcification 2.1.
> 
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> 
> Most unrelated question: do we need a min/max supported version for
> nvmet_subsys_attr_version_store?
> 
> 

By allowing user to set the min and max version it can definitely help
configure target version that is compliant with the host version, e.g.
if host only supports 1.3.0 then by setting max version to 1.3.0 in the
target subsystem will not execute any functionality that is added in
this series that belongs to only 2.1.0 version.

Is there any other reason ?

-ck