[PATCHv3 10/11] nvme: make independent ns identify default

Keith Busch kbusch at kernel.org
Tue Nov 5 12:29:45 PST 2024


On Tue, Nov 05, 2024 at 09:49:03AM -0800, Keith Busch wrote:
> @@ -4004,10 +4004,9 @@ static void nvme_scan_ns(struct nvme_ctrl *ctrl, unsigned nsid)
>  	 * data structure to find all the generic information that is needed to
>  	 * set up a namespace.  If not fall back to the legacy version.
>  	 */
> -	if ((ctrl->cap & NVME_CAP_CRMS_CRIMS) ||
> -	    (info.ids.csi != NVME_CSI_NVM && info.ids.csi != NVME_CSI_ZNS))
> +	if (ctrl->vs >= NVME_VS(2, 0, 0))
>  		ret = nvme_ns_info_from_id_cs_indep(ctrl, &info);

This should probably retain the previous conditions and just OR in the
2.0 check instead. I already made the change in my local branch, it
looks like this:

	if ((ctrl->cap & NVME_CAP_CRMS_CRIMS) ||
	    (info.ids.csi != NVME_CSI_NVM && info.ids.csi != NVME_CSI_ZNS) ||
	    ctrl->vs >= NVME_VS(2, 0, 0))



More information about the Linux-nvme mailing list