[PATCHv3] nvme: use srcu for iterating namespace list

Keith Busch kbusch at kernel.org
Tue May 28 10:15:52 PDT 2024


On Fri, May 24, 2024 at 06:43:45PM +0200, Christoph Hellwig wrote:
> > -static inline bool nvme_get_ns(struct nvme_ns *ns)
> > +bool nvme_get_ns(struct nvme_ns *ns)
> >  {
> >  	return kref_get_unless_zero(&ns->kref);
> >  }
> > +EXPORT_SYMBOL_NS_GPL(nvme_get_ns, NVME_TARGET_PASSTHRU);
> 
> What actually needs the export in nvmet?  AFAICS the export only grows
> a new user in ioctl.c.

Yes, I copied that from the "nvme_put_ns()", but you're right, this one
does not need to be exported. I've removed that and applied to
nvme-6.10. Thanks



More information about the Linux-nvme mailing list