[PATCH] nvme-pci: silence a lockdep complaint

[Sagi Grimberg]

On 23/05/2024 16:19, Christoph Hellwig wrote:
> On Thu, May 23, 2024 at 04:02:43PM +0300, Sagi Grimberg wrote:
>> I just want to have good testing before we touch these areas that
>> are all done in ctrl reset and error recovery which historically manifest
>> most of the issues...
>>
>> and all this because lockdep complains on false-positives...
> I still haven't seen any proof that it is a false-positive.
>

The explanation is that the nvme-pci timeout handler will only disable 
the device when either
it is able to transition the ctrl state to RESETTING or if the ctrl 
state is terminal, and in both
cases the reset_work is not running concurrently...

It was also proposed moving the call to nvme_disable_ctrl to a different 
context (returning BLK_RESET_TIMER from
the timeout handler) such that blk_sync_queue() does not depend on it. 
But Keith said it won't solve the issue.

Keith spent more time thinking about this, so I'll defer to him. I just 
want it to stop bothering Shinichiro and
others running blktests regularly...