[PATCH 3/5] block/bdev: lift restrictions on supported blocksize
Hannes Reinecke
hare at suse.de
Sat May 11 02:15:54 PDT 2024
On 5/11/24 00:25, Matthew Wilcox wrote:
> On Fri, May 10, 2024 at 12:29:04PM +0200, hare at kernel.org wrote:
>> From: Hannes Reinecke <hare at suse.de>
>>
>> We now can support blocksizes larger than PAGE_SIZE, so lift
>> the restriction.
>
> Do we need to make this conditional on a CONFIG option? Not all
> architectures support THP yet ... which means they don't support
> large folios. We should fix that, but it is well below the cutoff line
> on my todo list.
Well. We will only ever trigger this if we _really_ encounter a block
device with a block size larger than PAGE_SIZE.
If which there currently are none (note to self: check NFS).
And the overall idea is that the logical blocksize is mandatory, ie the
device _cannot_ handle requests with shorter blocksizes.
We might be setting min_order == max_order, but again this can be
discussed once we get min_order working :-)
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare at suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
More information about the Linux-nvme
mailing list