[PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging

Tokunori Ikegami ikegami.t at gmail.com
Sun May 5 08:27:31 PDT 2024


On 2024/05/05 22:46, Sagi Grimberg wrote:
>>   requeue:
>> -    dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d\n",
>> -            ctrl->ctrl.nr_reconnects);
>> +    dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d of %d\n",
>> +         ctrl->ctrl.nr_reconnects, ctrl->ctrl.opts->max_reconnects);
>
> How about we do:
> "Failed reconnect attempt %d/%d\n"
>
> And the same for the successful reconnect:
> "Successfully reconnected (attempt %d/%d)\n"

Thanks for your suggestion. Looks good so just sent the version 2 patch 
as mentioned.




More information about the Linux-nvme mailing list