[PATCH blktests v4 16/17] nvme/{rc,016,017}: rename nvme_num_iter to NVME_NUM_ITER
Shin'ichiro Kawasaki
shinichiro.kawasaki at wdc.com
Sat May 4 01:14:47 PDT 2024
To follow uppercase letter guide of environment variables, rename
nvme_num_iter to NVME_NUM_ITER.
Reviewed-by: Daniel Wagner <dwagner at suse.de>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki at wdc.com>
---
Documentation/running-tests.md | 5 +++--
tests/nvme/016 | 2 +-
tests/nvme/017 | 2 +-
tests/nvme/rc | 2 +-
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/running-tests.md b/Documentation/running-tests.md
index 736ab48..7bd0885 100644
--- a/Documentation/running-tests.md
+++ b/Documentation/running-tests.md
@@ -117,8 +117,9 @@ The NVMe tests can be additionally parameterized via environment variables.
Run the tests with given image size in bytes. 'm', 'M', 'g' and 'G' postfix
are supported. This parameter had an old name 'nvme_img_size'. The old name
is still usable, but not recommended.
-- nvme_num_iter: 1000 (default)
- The number of iterations a test should do.
+- NVME_NUM_ITER: 1000 (default)
+ The number of iterations a test should do. This parameter had an old name
+ 'nvme_num_iter'. The old name is still usable, but not recommended.
### Running nvme-rdma and SRP tests
diff --git a/tests/nvme/016 b/tests/nvme/016
index a65cffd..d1fdb35 100755
--- a/tests/nvme/016
+++ b/tests/nvme/016
@@ -23,7 +23,7 @@ test() {
_setup_nvmet
local port
- local iterations="${nvme_num_iter}"
+ local iterations="${NVME_NUM_ITER}"
local loop_dev
loop_dev="$(losetup -f)"
diff --git a/tests/nvme/017 b/tests/nvme/017
index 4f14471..114be60 100755
--- a/tests/nvme/017
+++ b/tests/nvme/017
@@ -23,7 +23,7 @@ test() {
_setup_nvmet
local port
- local iterations="${nvme_num_iter}"
+ local iterations="${NVME_NUM_ITER}"
truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path)"
diff --git a/tests/nvme/rc b/tests/nvme/rc
index ef7b966..6fc0020 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -20,7 +20,7 @@ export def_subsysnqn="blktests-subsystem-1"
export def_subsys_uuid="91fdba0d-f87b-4c25-b80f-db7be1418b9e"
_check_conflict_and_set_default NVMET_TRTYPES nvme_trtype "loop"
_check_conflict_and_set_default NVME_IMG_SIZE nvme_img_size 1G
-nvme_num_iter=${nvme_num_iter:-"1000"}
+_check_conflict_and_set_default NVME_NUM_ITER nvme_num_iter 1000
nvmet_blkdev_type=${nvmet_blkdev_type:-"device"}
NVMET_BLKDEV_TYPES=${NVMET_BLKDEV_TYPES:-"device file"}
--
2.44.0
More information about the Linux-nvme
mailing list