[PATCH blktests v4 00/17] support test case repeat by different conditions
Shin'ichiro Kawasaki
shinichiro.kawasaki at wdc.com
Sat May 4 01:14:31 PDT 2024
In the recent discussion for nvme test group [1], two pain points were mentioned
regarding the test case runs.
1) Several test cases in nvme test group do exactly the same test except the
NVME transport backend set up condition difference (device vs. file). This
results in duplicate test script codes. It is desired to unify the test cases
and run them repeatedly with the different conditions.
2) NVME transport types can be specified with nvme_trtype parameter so that the
same tests can be run for various transport types. However, some test cases
do not depend on the transport types. They are repeated in multiple runs for
the various transport types under the exact same conditions. It is desired to
repeat the test cases only when such repetition is required.
[1] https://lore.kernel.org/linux-block/w2eaegjopbah5qbjsvpnrwln2t5dr7mv3v4n2e63m5tjqiochm@uonrjm2i2g72/
One idea to address these pain points is to add the test repeat feature to the
nvme test group. However, Daniel questioned if the feature could be implemented
in the blktests framework. Actually, a similar feature has already been
implemented to repeat some test cases for non-zoned block devices and zoned
block devices. However, this feature is implemented only for the zoned and non-
zoned device conditions. It can not fulfill the desires for nvme test group.
This series proposes to generalize the feature in the blktests framework to
repeat the test cases with different conditions. Introduce a new function
set_conditions() that each test case can define and instruct the framework to
repeat the test case. This series applies this feature to nvme test group so
that the test cases can be repeated for NVME transport types and backend types
in the ideal way. For this purpose, this series introduces new config parameters
NVMET_TRTYPES and NVMET_BLKDEV_TYPES. Taking this chance, it renames other
lowercase config parameters nvme_img_size, nvme_num_iter and use_rxe to
uppercase to follow the guide for environment variables.
The first six patches introduce the feature and apply it to the repetition for
non-zoned and zoned block devices. The seventh patch introduces a helper
function to prepare config parameter rename to uppercase. The following seven
patches apply the test case repeat feature to nvme group. Three of the seven
patches are reused from the work by Daniel. The last three patches rename the
config parameters. The all patches are listed in the order that does not lose
the test coverage with the default set up.
As an example of the repeated test run, let's say NVMET_TRTYPES and
NVMET_BLKDEV_TYPES are defined in the config file as follows:
NVMET_TRTYPES="loop rdma tcp"
NVMET_BLKDEV_TYPES="device file"
In this case, the test cases which depend on these parameters are repeated
3 x 2 = 6 times. For example, nvme/006 is repeated as follows.
nvme/006 (tr=loop bd=device) (create an NVMeOF target) [passed]
runtime ... 0.097s
nvme/006 (tr=rdma bd=device) (create an NVMeOF target) [passed]
runtime 0.138s ... 0.134s
nvme/006 (tr=tcp bd=device) (create an NVMeOF target) [passed]
runtime ... 0.101s
nvme/006 (tr=loop bd=file) (create an NVMeOF target) [passed]
runtime ... 0.083s
nvme/006 (tr=rdma bd=file) (create an NVMeOF target) [passed]
runtime 0.129s ... 0.129s
nvme/006 (tr=tcp bd=file) (create an NVMeOF target) [passed]
runtime ... 0.093s
Changes from v3:
* 5th and 6th patches: added _set_combined_conditions() for ease of maintainance
* 10th patch: modified to drop _set_nvme_trtype_and_nvmet_blkdev_type()
* 12th and 14th patches: applied _set_combined_conditions()
* Applied Reviewed-by tags
Changes from v2:
* 5th patch: added to prepare for the parameter rename
* 6th patch: modified nvme_trtype description and added NVMET_TRTYPES check
* 13-15th patches: added for the parameter rename
* Applied Reviewed-by tags
* Rebased to the latest master branch tip
Changes from v1:
* Renamed NVMET_TR_TYPES to NVMET_TRTYPES
* 1st patch: reflected comments on the list and added Reviewed-by tag
* 5th patch: changed NVMET_TRTYPES from array to variable
* 7th patch: changed NVMET_BLKDEV_TYPES from array to variable
* Reflected other comments on the list
Daniel Wagner (3):
nvme/rc: add blkdev type environment variable
nvme/{007,009,011,013,015,020,024}: drop duplicate nvmet blkdev type
tests
nvme/{021,022,025,026,027,028}: do not hard code target blkdev type
Shin'ichiro Kawasaki (14):
check: factor out _run_test()
check: support test case repeat by different conditions
check: use set_conditions() for the CAN_BE_ZONED test cases
meta/{016,017}: add test cases to check repeated test case runs
common/rc: introduce _set_combined_conditions
meta/{018,019}: add test cases to check _set_combined_conditions
common/rc: introduce _check_conflict_and_set_default()
nvme/rc: introduce NVMET_TRTYPES
nvme/rc: introduce NVMET_BLKDEV_TYPES
nvme/{002-031,033-038,040-045,047,048}: support NMVET_TRTYPES
nvme/{006,008,010,012,014,019,023}: support NVMET_BLKDEV_TYPES
nvme/{rc,010,017,031,034,035}: rename nvme_img_size to NVME_IMG_SIZE
nvme/{rc,016,017}: rename nvme_num_iter to NVME_NUM_ITER
nvme/rc,srp/rc,common/multipath-over-rdma: rename use_rxe to USE_RXE
Documentation/running-tests.md | 33 ++++++---
Makefile | 3 +-
check | 129 ++++++++++++++++++++++-----------
common/multipath-over-rdma | 5 +-
common/rc | 72 ++++++++++++++++++
common/shellcheck | 2 +-
common/zoned | 22 ++++++
new | 21 ++++++
tests/meta/016 | 29 ++++++++
tests/meta/016.out | 2 +
tests/meta/017 | 29 ++++++++
tests/meta/017.out | 2 +
tests/meta/018 | 43 +++++++++++
tests/meta/018.out | 2 +
tests/meta/019 | 55 ++++++++++++++
tests/meta/019.out | 2 +
tests/meta/rc | 5 ++
tests/nvme/002 | 4 +
tests/nvme/003 | 4 +
tests/nvme/004 | 4 +
tests/nvme/005 | 4 +
tests/nvme/006 | 8 +-
tests/nvme/007 | 27 -------
tests/nvme/007.out | 2 -
tests/nvme/008 | 8 +-
tests/nvme/009 | 36 ---------
tests/nvme/009.out | 3 -
tests/nvme/010 | 10 ++-
tests/nvme/011 | 39 ----------
tests/nvme/011.out | 3 -
tests/nvme/012 | 8 +-
tests/nvme/013 | 43 -----------
tests/nvme/013.out | 3 -
tests/nvme/014 | 8 +-
tests/nvme/015 | 48 ------------
tests/nvme/015.out | 4 -
tests/nvme/016 | 6 +-
tests/nvme/017 | 8 +-
tests/nvme/018 | 4 +
tests/nvme/019 | 8 +-
tests/nvme/020 | 40 ----------
tests/nvme/020.out | 4 -
tests/nvme/021 | 10 ++-
tests/nvme/022 | 10 ++-
tests/nvme/023 | 8 +-
tests/nvme/024 | 40 ----------
tests/nvme/024.out | 2 -
tests/nvme/025 | 10 ++-
tests/nvme/026 | 10 ++-
tests/nvme/027 | 10 ++-
tests/nvme/028 | 10 ++-
tests/nvme/029 | 4 +
tests/nvme/030 | 4 +
tests/nvme/031 | 6 +-
tests/nvme/033 | 4 +
tests/nvme/034 | 6 +-
tests/nvme/035 | 8 +-
tests/nvme/036 | 4 +
tests/nvme/037 | 4 +
tests/nvme/038 | 4 +
tests/nvme/040 | 4 +
tests/nvme/041 | 3 +
tests/nvme/042 | 3 +
tests/nvme/043 | 3 +
tests/nvme/044 | 3 +
tests/nvme/045 | 3 +
tests/nvme/047 | 4 +
tests/nvme/048 | 4 +
tests/nvme/rc | 68 ++++++++++++++---
tests/srp/rc | 2 +-
70 files changed, 639 insertions(+), 404 deletions(-)
create mode 100644 common/zoned
create mode 100755 tests/meta/016
create mode 100644 tests/meta/016.out
create mode 100755 tests/meta/017
create mode 100644 tests/meta/017.out
create mode 100755 tests/meta/018
create mode 100644 tests/meta/018.out
create mode 100755 tests/meta/019
create mode 100644 tests/meta/019.out
delete mode 100755 tests/nvme/007
delete mode 100644 tests/nvme/007.out
delete mode 100755 tests/nvme/009
delete mode 100644 tests/nvme/009.out
delete mode 100755 tests/nvme/011
delete mode 100644 tests/nvme/011.out
delete mode 100755 tests/nvme/013
delete mode 100644 tests/nvme/013.out
delete mode 100755 tests/nvme/015
delete mode 100644 tests/nvme/015.out
delete mode 100755 tests/nvme/020
delete mode 100644 tests/nvme/020.out
delete mode 100755 tests/nvme/024
delete mode 100644 tests/nvme/024.out
--
2.44.0
More information about the Linux-nvme
mailing list