[RFC blktests v1 02/10] nvme/{012,013,035}: check return value of _xfs_run_fio_verify_io
Daniel Wagner
dwagner at suse.de
Mon Mar 18 02:38:47 PDT 2024
When _xfs_run_fio_verify_io fails we should log the error. Currently, no
failure is detected when this function fails.
Signed-off-by: Daniel Wagner <dwagner at suse.de>
---
tests/nvme/012 | 4 +++-
tests/nvme/013 | 4 +++-
tests/nvme/035 | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/tests/nvme/012 b/tests/nvme/012
index c5e0eb9c5e23..f0914ce3206b 100755
--- a/tests/nvme/012
+++ b/tests/nvme/012
@@ -33,7 +33,9 @@ test() {
nvmedev=$(_find_nvme_dev "${def_subsysnqn}")
_check_uuid "${nvmedev}"
- _xfs_run_fio_verify_io "/dev/${nvmedev}n1"
+ if ! _xfs_run_fio_verify_io "/dev/${nvmedev}n1"; then
+ echo "FAIL: fio verify failed"
+ fi
_nvme_disconnect_subsys "${def_subsysnqn}"
diff --git a/tests/nvme/013 b/tests/nvme/013
index 3ec280ff24cf..3cef009cb9f4 100755
--- a/tests/nvme/013
+++ b/tests/nvme/013
@@ -32,7 +32,9 @@ test() {
nvmedev=$(_find_nvme_dev "${def_subsysnqn}")
_check_uuid "${nvmedev}"
- _xfs_run_fio_verify_io "/dev/${nvmedev}n1"
+ if ! _xfs_run_fio_verify_io "/dev/${nvmedev}n1"; then
+ echo "FAIL: fio verify failed"
+ fi
_nvme_disconnect_subsys "${def_subsysnqn}"
diff --git a/tests/nvme/035 b/tests/nvme/035
index 712fe1dbcfb8..01aa09077d6a 100755
--- a/tests/nvme/035
+++ b/tests/nvme/035
@@ -31,7 +31,9 @@ test_device() {
_nvmet_passthru_target_setup "${def_subsysnqn}"
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
- _xfs_run_fio_verify_io "${nsdev}" "${nvme_img_size}"
+ if ! _xfs_run_fio_verify_io "${nsdev}" "${nvme_img_size}"; then
+ echo "FAIL: fio verify failed"
+ fi
_nvme_disconnect_subsys "${def_subsysnqn}"
_nvmet_passthru_target_cleanup "${def_subsysnqn}"
--
2.44.0
More information about the Linux-nvme
mailing list