[PATCH 14/26] block: move the nonrot flag to queue_limits
Christoph Hellwig
hch at lst.de
Mon Jun 24 10:24:25 PDT 2024
On Mon, Jun 24, 2024 at 11:08:16AM -0600, Keith Busch wrote:
> On Mon, Jun 17, 2024 at 08:04:41AM +0200, Christoph Hellwig wrote:
> > -#define blk_queue_nonrot(q) test_bit(QUEUE_FLAG_NONROT, &(q)->queue_flags)
> > +#define blk_queue_nonrot(q) ((q)->limits.features & BLK_FEAT_ROTATIONAL)
>
> This is inverted. Should be:
>
> #define blk_queue_nonrot(q) (!((q)->limits.features & BLK_FEAT_ROTATIONAL))
Ah yes. And the sysfs attribute doesn't go through the macro and
won't show the effect. I'll send a fixup.
More information about the Linux-nvme
mailing list