[PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy

John Meneghini jmeneghi at redhat.com
Mon Jun 24 10:50:21 PDT 2024


On 6/24/24 04:46, Christoph Hellwig wrote:
> On Thu, Jun 20, 2024 at 01:54:29PM -0400, John Meneghini wrote:
>> How about:
>>
>> pr_notice("Changed iopolicy from %s to %s for subsysnqn %s\n",
>>                  nvme_iopolicy_names[old_iopolicy],
>>                  nvme_iopolicy_names[iopolicy],
>>                  subsys->subnqn);
> 
> Having the identification as the prefixe seems easier to parse
> and grep for.

To be clear Christoph, your saying you'd like the NQN in the prefix of the dmesg?

E.g.:

root> echo "round-robin" > /sys/class/nvme-subsystem/nvme-subsys11/iopolicy
[Thu Jun 24 11:44:20 2024] subsysnqn nqn.1992-08.com.netapp:sn.2b82d9b13bb211ee8744d039ea989119:subsystem.SS104a iopolicy 
changed from queue-depth to round-robin.

Correct?

/John




More information about the Linux-nvme mailing list