move integrity settings to queue_limits v3
Christoph Hellwig
hch at lst.de
Thu Jun 13 01:48:10 PDT 2024
Hi Jens, hi Martin,
this series converts the blk-integrity settings to sit in the queue
limits and be updated through the atomic queue limits API.
I've mostly tested this with nvme, scsi is only covered by simple
scsi_debug based tests.
For MD I found an pre-existing error handling bug when combining PI
capable devices with not PI capable devices. The fix was posted here
(and is included in the git branch below):
https://lore.kernel.org/linux-raid/20240604172607.3185916-1-hch@lst.de/
For dm-integrity my testing showed that even the baseline fails to create
the luks-based dm-crypto with dm-integrity backing for the authentication
data. As the failure is non-fatal I've not addressed it here.
Note that the support for native metadata in dm-crypt by Mikulas will
need a rebase on top of this, but as it already requires another
block layer patch and the changes in this series will simplify it a bit
I hope that is ok.
The series is based on top of my previously sent "convert the SCSI ULDs
to the atomic queue limits API v2" API.
A git tree is available here:
git://git.infradead.org/users/hch/block.git block-integrity-limits
Gitweb:
http://git.infradead.org/?p=users/hch/block.git;a=shortlog;h=refs/heads/block-integrity-limits
Changes since v2:
- keep the unused BIP_CTRL_NOCHECK, BIP_DISK_NOCHECK and
BIP_IP_CHECKSUM flags for now
Changes since v1:
- keep generating (empty) non-PI metadata
- use a packed enum for the csum type
- remove an unused flag left in the code
Diffstat:
Documentation/block/data-integrity.rst | 49 ------
block/Kconfig | 8 -
block/Makefile | 3
block/bio-integrity.c | 43 +++--
block/blk-integrity.c | 229 ++++++++----------------------
block/blk-mq.c | 13 -
block/blk-settings.c | 118 ++++++++++++++-
block/blk.h | 8 +
block/t10-pi.c | 249 +++++++++++----------------------
drivers/md/dm-core.h | 1
drivers/md/dm-crypt.c | 4
drivers/md/dm-integrity.c | 47 +-----
drivers/md/dm-table.c | 161 +++------------------
drivers/md/md.c | 72 ++-------
drivers/md/md.h | 5
drivers/md/raid0.c | 28 +--
drivers/md/raid1.c | 24 +--
drivers/md/raid10.c | 10 -
drivers/md/raid5.c | 2
drivers/nvdimm/btt.c | 13 -
drivers/nvme/host/Kconfig | 1
drivers/nvme/host/core.c | 71 ++++-----
drivers/nvme/host/multipath.c | 3
drivers/nvme/target/Kconfig | 1
drivers/nvme/target/io-cmd-bdev.c | 16 +-
drivers/scsi/Kconfig | 1
drivers/scsi/sd.c | 8 -
drivers/scsi/sd.h | 12 -
drivers/scsi/sd_dif.c | 45 ++---
drivers/target/target_core_iblock.c | 49 +++---
include/linux/blk-integrity.h | 62 ++------
include/linux/blkdev.h | 25 ++-
include/linux/t10-pi.h | 20 --
33 files changed, 533 insertions(+), 868 deletions(-)
More information about the Linux-nvme
mailing list