[PATCH v6 1/1] nvme-multipath: implement "queue-depth" iopolicy

John Meneghini jmeneghi at redhat.com
Wed Jun 12 06:07:33 PDT 2024


On 6/11/24 21:44, Chaitanya Kulkarni wrote:
>>    /*
>>     * List of workarounds for devices that required behavior not specified in
>>     * the standard.
>> @@ -195,6 +197,7 @@ enum {
>>    	NVME_REQ_CANCELLED		= (1 << 0),
>>    	NVME_REQ_USERCMD		= (1 << 1),
>>    	NVME_MPATH_IO_STATS		= (1 << 2),
>> +	NVME_MPATH_CNT_ACTIVE	= (1 << 3),
> nit:- please align above to existing code ...

Ok... there must be something wrong with my tab stop.... are we using 8 space tabs in linux?

Here's what I have in my .vimrc

set smartindent              " always set smartindenting on
set autoindent               " always set autoindenting on
set backspace=2              " Influences the working of <BS>, <Del>, CTRL-W and CTRL-U in Insert mode.
set noexpandtab              " insert tabs instead of spaces
set textwidth=0              " Don't wrap words by default
set shiftwidth=4 smarttab    " number of spaces to use for each step of indent
set tabstop=4 softtabstop=0  " setting tab stops to be different from the indentation width

What is recommended setting for these ?

set shiftwidth=8 ?
set tabstop=8 ?

/John




More information about the Linux-nvme mailing list