[PATCH 19/26] block: move the nowait flag to queue_limits
Christoph Hellwig
hch at lst.de
Tue Jun 11 22:01:09 PDT 2024
On Tue, Jun 11, 2024 at 05:16:37PM +0900, Damien Le Moal wrote:
> > @@ -1825,9 +1815,7 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
> > int r;
> >
> > if (dm_table_supports_nowait(t))
> > - blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q);
> > - else
> > - blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);
> > + limits->features &= ~BLK_FEAT_NOWAIT;
>
> Shouldn't you set the flag here instead of clearing it ?
No, but the dm_table_supports_nowait check needs to be inverted.
More information about the Linux-nvme
mailing list