[PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics
Christoph Hellwig
hch at lst.de
Mon Jun 10 22:52:39 PDT 2024
On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
> > - if (lim->zoned)
> > + if (sdkp->device->type == TYPE_ZBC)
>
> Nit: use sd_is_zoned() here ?
Yes.
> > - if (!sd_is_zoned(sdkp))
> > + if (!sd_is_zoned(sdkp)) {
> > + lim->zoned = false;
>
> Maybe we should clear the other zone related limits here ? If the drive is
> reformatted/converted from SMR to CMR (FORMAT WITH PRESET), the other zone
> limits may be set already, no ?
blk_validate_zoned_limits already takes care of that.
More information about the Linux-nvme
mailing list