[PATCH 11/11] block: move integrity information into queue_limits

Christoph Hellwig hch at lst.de
Fri Jun 7 07:52:20 PDT 2024


On Fri, Jun 07, 2024 at 09:35:02AM +0200, Hannes Reinecke wrote:
>>> +?????? if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) {
>>> +?????????????? pr_warn("integrity support disabled.\n");
>>> +?????????????? return -EINVAL;
>>> +?????? }
>>> +
>> Why is that an error?
>> Surely 'validate' should not return an error if BLK_DEV_INTEGRITY is 
>> disabled and no limits are set?

Look a few lines above, we'll never get here if no tuple_size is set,
which is now the indicator for metadata support.




More information about the Linux-nvme mailing list