[PATCH 05/11] block: remove the blk_flush_integrity call in blk_integrity_unregister

[Hannes Reinecke]

On 6/7/24 07:58, Christoph Hellwig wrote:
> Now that there are no indirect calls for PI processing there is no
> way to dereference a NULL pointer here.  Additionally drivers now always
> freeze the queue (or in case of stacking drivers use their internal
> equivalent) around changing the integrity profile.
> 
> This is effectively a revert of commit 3df49967f6f1 ("block: flush the
> integrity workqueue in blk_integrity_unregister").
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
>   block/blk-integrity.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/block/blk-integrity.c b/block/blk-integrity.c
> index 17d37badfbb8bc..24f04575096d39 100644
> --- a/block/blk-integrity.c
> +++ b/block/blk-integrity.c
> @@ -401,8 +401,6 @@ void blk_integrity_unregister(struct gendisk *disk)
>   	if (!bi->tuple_size)
>   		return;
>   
> -	/* ensure all bios are off the integrity workqueue */
> -	blk_flush_integrity();
>   	blk_queue_flag_clear(QUEUE_FLAG_STABLE_WRITES, disk->queue);
>   	memset(bi, 0, sizeof(*bi));
>   }

Reviewed-by: Hannes Reinecke <hare at suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich