[PATCH v2 2/4] nvme: fix status magic numbers
Chaitanya Kulkarni
chaitanyak at nvidia.com
Tue Jun 4 17:02:19 PDT 2024
On 6/3/24 05:57, Weiwen Hu wrote:
> Replaced some magic numbers about SC and SCT with enum and macro.
>
> Signed-off-by: Weiwen Hu <huweiwen at linux.alibaba.com>
> ---
[...]
> @@ -1223,7 +1223,7 @@ EXPORT_SYMBOL_NS_GPL(nvme_passthru_end, NVME_TARGET_PASSTHRU);
>
> /*
> * Recommended frequency for KATO commands per NVMe 1.4 section 7.12.1:
> - *
> + *
> * The host should send Keep Alive commands at half of the Keep Alive Timeout
> * accounting for transport roundtrip times [..].
> */
looks bit odd to have in this patch without the commit log,
but if everyone is okay ignore this comment, Looks good.
Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
-ck
More information about the Linux-nvme
mailing list