[PATCH 5/9] nvme: split off TLS sysfs attributes into a separate group

[Sagi Grimberg]

>> I would have also kinda expected that this attribute group lives in
>> tcp.c, is there a good reason to keep it in the core code?
>>
> I knew this argument would be coming.
> Thing is: these options depend on CONFIG_NVME_TCP_TLS, so
> they will always be encapsulated in some #ifdef, be it in sysfs.c
> or in tcp.c.
>
> And as we always will have to have an #ifdef in one of the files
> I thought it easier to keep it in sysfs.c, and save us having to
> have an exported attribute_group which might even be empty.
>
> But if you insist ...

I think that tls awareness has already leaked to core code (for good 
reasons I think),
so at this point I'm fine either way....