[PATCH] nvme-pci: Fix the instructions for disabling power management

[Keith Busch]

On Thu, Jul 11, 2024 at 12:10:11PM -0700, Bart Van Assche wrote:
> On 7/11/24 12:01 PM, Keith Busch wrote:
> > On Wed, Jul 10, 2024 at 04:18:05PM -0700, Bart Van Assche wrote:
> > > pcie_aspm=off tells the kernel not to modify the ASPM configuration. This
> > > setting does not guarantee that ASPM (Active State Power Management) is
> > > disabled. pcie_port_pm=off disables power management for all PCIe ports.
> > > 
> > > This patch has been tested on a workstation with a Samsung SSD 970 EVO Plus
> > > NVMe SSD.
> > 
> > Interesting, didn't know about that parameter. Does this actually aspm
> > too, though? It looks like we want aspm policy to be performance for
> > that to happen.
> 
> Hi Keith,
> 
> I don't know the answer to your question. All I know is that the
> settings from this patch are required to make the SSD mentioned above
> work reliably.

Okay, do you think we could just append the new parameter to the
existing recommendation rather than replace the aspm one? I could swear
I recall some platform where pcie_aspm=off did fix something, but it's
been a while.