[PATCH v2 0/3] *** nvme: add some commands tracing ***
Chaitanya Kulkarni
chaitanyak at nvidia.com
Wed Jan 31 15:08:52 PST 2024
Guixin,
On 1/31/24 01:12, Guixin Liu wrote:
> Hi guys:
> I found that there are no reservation commands tracing and some
> commands's parsing aren't fit the newest NVMe spec, and aren't readble.
>
> Changes from v1 to v2:
> - Remove idr and idw parsing of dsm command.
>
> - Remove lbafl and lbafu variables and add a comment for the lbaf
> calculation in nvme_trace_admin_format_nvm().
>
> Guixin Liu (3):
> nvme: add tracing of reservation commands
> nvme: parse dsm command's attr deallocate when tracing
> nvme: parse format command's lbafu when tracing
>
> drivers/nvme/host/trace.c | 73 ++++++++++++++++++++++++++++++++++++---
> 1 file changed, 69 insertions(+), 4 deletions(-)
>
One suggestion can you please not add *** in the subject line ? that
is not a common practice on the mailing list.
This series addresses the comments posted in the last version.
Looks good, for the entire series :-
Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
-ck
More information about the Linux-nvme
mailing list