[PATCH] nvme-common: add module description

Sagi Grimberg sagi at grimberg.me
Wed Jan 31 13:01:23 PST 2024


> Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-auth.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-keyring.o
> 
> Signed-off-by: Chaitanya Kulkarni <kch at nvidia.com>
> ---
>   drivers/nvme/common/auth.c    | 1 +
>   drivers/nvme/common/keyring.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/common/auth.c b/drivers/nvme/common/auth.c
> index a23ab5c968b9..b707e6b7d263 100644
> --- a/drivers/nvme/common/auth.c
> +++ b/drivers/nvme/common/auth.c
> @@ -471,4 +471,5 @@ int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key)
>   }
>   EXPORT_SYMBOL_GPL(nvme_auth_generate_key);
>   
> +MODULE_DESCRIPTION("NVMe Authentication framework");
>   MODULE_LICENSE("GPL v2");
> diff --git a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> index a5c0431c101c..394c3948e339 100644
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -181,5 +181,6 @@ static void __exit nvme_keyring_exit(void)
>   
>   MODULE_LICENSE("GPL v2");
>   MODULE_AUTHOR("Hannes Reinecke <hare at suse.de>");
> +MODULE_DESCRIPTION("NVMe TLS Keyring implementation");

iirc, I think Hannes had an intention to make the inband auth
implementation to use nvme keyring as well. So I'd omit TLS from
the description.

Other than that,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>



More information about the Linux-nvme mailing list